Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some information about building the docker image locally #1080

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add some information about building the docker image locally #1080

merged 5 commits into from
Sep 25, 2024

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Adds a slightly more fleshed out version of the instructions on the V6 readme. Includes some examples for users who are asked to checkout alternative branches

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from DL6ER August 23, 2024 17:59
@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 424ddf6
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/66e2055342fe180008b3ebfd
😎 Deploy Preview https://deploy-preview-1080--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PromoFaux
Tweaks following feedback
e4c6e35 
Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux requested a review from DL6ER August 23, 2024 18:41
@PromoFaux @yubiuser
Update docs/docker/build-image.md
a686604 
Co-authored-by: yubiuser <[email protected]>
Signed-off-by: Adam Warner <[email protected]>
yubiuser
yubiuser requested changes Sep 2, 2024
View reviewed changes
docs/docker/build-image.md Outdated Show resolved Hide resolved
@PromoFaux PromoFaux merged commit 5ef5a90 into release/v6.0 Sep 25, 2024
10 checks passed
@PromoFaux PromoFaux deleted the new/dockerDocs branch September 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

@DL6ER DL6ER Awaiting requested review from DL6ER

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PromoFaux @DL6ER @yubiuser